Re: [PATCH] i2c: designware: Fix false warning from i2c_dw_clk_rate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +	switch (dev->master_cfg & DW_IC_CON_SPEED_MASK) {
> > +	case DW_IC_CON_SPEED_STD:
> > +		i2c_dw_set_timings_sm(dev);
> > +		break;
> > +	case DW_IC_CON_SPEED_FAST:
> > +		i2c_dw_set_timings_fm(dev);
> > +		break;
> > +	case DW_IC_CON_SPEED_HIGH:
> > +		i2c_dw_set_timings_hsm(dev);
> > +		break;
> >  	}
> 
> I would put same suffixes to the helper functions, i.e.
> _sm -> _std
> _fm -> _fast
> _hsm-> _high

BTW is this a bugfix? I tend to think, yes.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux