Hi Jan, > What is missing in the pci-driver for ACPI support? We already use ACPI > to detect the sclk setting. I noticed this in the driver: 134 static int thunder_i2c_smbus_setup(struct octeon_i2c *i2c, 135 struct device_node *node) 136 { 137 /* TODO: ACPI support */ 138 if (!acpi_disabled) 139 return -EOPNOTSUPP; 140 141 return thunder_i2c_smbus_setup_of(i2c, node); 142 } And from a glimpse, I assumed this is the place to detect and instantiate client devices. > So, if you're ok with this I'll re-phrase the commit message and > re-submit the patch. I'm OK. It is basically your call. I just wanted to make sure you know what it means adding the class to a master driver. Regards, Wolfram
Attachment:
signature.asc
Description: PGP signature