Hi Peter,
> + int values[mux->data.n_gpios];
Hmm, my code checkers complain about this line:
CHECK drivers/i2c/muxes/i2c-mux-gpio.c
SPARSE
drivers/i2c/muxes/i2c-mux-gpio.c:29:29: warning: Variable length array is used.
SMATCH
drivers/i2c/muxes/i2c-mux-gpio.c:29:29: warning: Variable length array is used.
Worth to fix it?
BTW (unrelated to your patch), the compiler complains about:
In file included from drivers/i2c/muxes/i2c-mux-gpio.c:18:0:
drivers/i2c/muxes/../../gpio/gpiolib.h:88:27: warning: ‘gpio_suffixes’ defined but not used [-Wunused-const-variable=]
static const char * const gpio_suffixes[] = { "gpios", "gpio" };
which pointed out this line to me:
18 #include "../../gpio/gpiolib.h"
which is probably worth fixing, too?
Thanks,
Wolfram
Attachment:
signature.asc
Description: PGP signature
