> > You could have left the original 'return' instead of the 2 new ones, but > > you decide. > > Yes I know, but I wanted to ensure for runtime-pm we only return 0 on > success. Yes clk_enable should only return 0 on success and a negative > error code otherwise, but I prefer this. So will leave as-is. OK. > > >> - if (tegra_i2c_flush_fifos(i2c_dev)) > >> - err = -ETIMEDOUT; > >> + err = tegra_i2c_flush_fifos(i2c_dev); > > > > 'err' is assigned but where is it checked? > > It will be returned by the function. This is no different to how it > works today if you look at the code. I did think about checking it right I agree. I missed it before, thanks for the heads up.
Attachment:
signature.asc
Description: PGP signature
