On Mon, Jun 27, 2016 at 4:17 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Fri, Jun 17, 2016 at 02:52:13PM +0300, Octavian Purdila wrote: > >> This patch adds supports for SPI device enumeration and removal via >> ACPI reconfiguration notifications that are send as a result of an >> ACPI table load or unload operation. > > I still have the same concern I've had all the way through here: this is > very similar to the equivalent DT code but not quite, especially in > regard to the OF_POPULATED flag which has no ACPI equivalent. This > gives us ACPI code which just looks like it's missing something. I'd > like to see the comparison at least covered in the changelog so people > have something to refer to in future when trying to understand why > things are done this way. I agree here. Tavi, please extend the changelog as requested by Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html