Re: Question about I2C driver upstream from same SoC vendor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Cedric,

> I am wondering if it is the good way of working as I noticed that many
> maintainers prefer to have one driver that support all IPs of the same
> SoC vendor ?

Really? That doesn't sound too healthy to me...

> In our case, I think it will be possible to support both I2C IPs in
> one driver called i2c-stm32.c but the code will run of readability and
> will be difficult to maintain...

I think a driver should handle the same or similar IP cores. Quite the
contrary, the same IP cores can be found in SoCs from different vendors.
They should then *still* be handled by the same driver. I usually
compare register sets to decide which way to go.

For your case, this sounds pretty much like a second driver. Good you
asked beforehand.

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux