On 14 June 2016 at 17:35, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Tue, 2016-06-14 at 17:07 +0200, Ulf Hansson wrote: >> The current code that deploys the system PM support relies on the >> "direct_complete" feature supported by the PM core. The goal is to >> avoid >> performing unnecessary operations during the system PM sequence. >> > >> >> static const struct dev_pm_ops dw_i2c_dev_pm_ops = { >> - .prepare = dw_i2c_plat_prepare, >> - .complete = dw_i2c_plat_complete, >> - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, >> dw_i2c_plat_resume) >> - SET_RUNTIME_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume, >> NULL) >> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, >> + pm_runtime_force_resume) >> + SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, >> + dw_i2c_plat_runtime_resume, >> + NULL) >> }; > > UNIVERSAL_PM_OPS ? The UNIVERSAL_DEV_PM_OPS assigns the same callbacks for system PM as runtime PM, that doesn't work here. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html