On Thu, Jun 09, 2016 at 10:11:51PM +0200, Wolfram Sang wrote: > On Wed, Jun 08, 2016 at 08:51:18AM +0200, Jan Glauber wrote: > > The controller specification states that when receiving STAT_RXADDR_NAK > > the START should be sent again. Retry several times before finally > > failing with -ENXIO. > > > > Without this change the IPMI SSIF driver fails executing several commands > > like 'ipmitool fru' on ThunderX. > > Huh? Looks wrong to me. I'd say the client driver needs to retry. Only > that one knows if retrying is appropriate or a waste of time. > I've been debugging this and it turned out that there was an related issue with the clock setting. With that corrected this patch is not needed anymore, so you can drop it. I still see a huge number of RXADDR_NAK's after START but the ipmi_ssif driver retry logic seems to deal with that. thanks, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
