Re: [PATCH] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 02, 2016 at 11:29:01PM +0200, Rafael J. Wysocki wrote:
> It doesn't look like trying to make it safe for both the driver and
> AML to use the same range of addresses is a realistic goal.  At least
> the benefit will not outweigh the resulting complexity if the opregion
> is actually never used by AML in practice.
> 
> So, why don't we have a flag that will make i801_access() return an
> error on every invocation when set (the callers of it should be able
> to cope with that or they are broken IMO) and why don't we set it when
> AML accesses the opregion first time?

Yeah, that occured to me also yesterday evening :)

> Yes, that will prevent the driver from actually working *when* AML
> turns out to use the opregion, but IMO that's a bit more friendly than
> preventing the driver from loading at all.

I agree. If nobody objects, I'm going to create v2 of the patch that
prevents further driver access if AML touches the OpRegion.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux