On Tue, Jan 26, 2016 at 07:14:40PM +0300, Dmitriy Baranov wrote: > Add I2C slave provider using the generic slave interface. > It also supports master transactions when the slave in the idle mode. > > Issues: > Changes work only in PIO mode (when driver doesn`t use DMA) This is fine with me. We don't support block transfers currently in the slave core anyhow. > There are might be race conditions. Can you name them > +enum imx_i2c_slave_state { > + I2C_IMX_SLAVE_IDLE, > + I2C_IMX_SLAVE_IRQ, > + I2C_IMX_SLAVE_POLLING Highlevel question first: Why do you have polling? Why would anyone not want to use interrupts here?
Attachment:
signature.asc
Description: PGP signature