On 02/02/2016 03:33 PM, Jean Delvare wrote:
Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for
proper Kconfig dependencies") claims that the "Baytrail driver" isn't
tristate. But in fact there is no such thing as a "Baytrail driver",
i2c-designware-baytrail is not a stand-alone driver but an optional
addition to the i2c-designware-platform driver, and that driver *is*
tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't
be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.
I had a similar patch waiting for David's ack because I didn't know are
there any problems when IOSF_MBI is module but I forgot to ping again.
David: can you ack this in case IOSF_MBI=m is ok.
Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Fixes: b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies")
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
Cc: Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.5-rc2.orig/drivers/i2c/busses/Kconfig 2016-02-02 13:36:02.621152859 +0100
+++ linux-4.5-rc2/drivers/i2c/busses/Kconfig 2016-02-02 14:06:07.185912775 +0100
@@ -490,7 +490,7 @@ config I2C_DESIGNWARE_PCI
config I2C_DESIGNWARE_BAYTRAIL
bool "Intel Baytrail I2C semaphore support"
- depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI
+ depends on I2C_DESIGNWARE_PLATFORM && (IOSF_MBI=y || IOSF_MBI=I2C_DESIGNWARE_PLATFORM) && ACPI
One minor comment: could you split this into two depends on lines in
order to avoid long lines?
Reviewed-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
