On Fri, Jan 22, 2016 at 02:12:02PM +0100, Jean Delvare wrote: > We need a single mutex for all 4 shared SMBus ports on the SB800. A > per-port mutex doesn't protect us from concurrent access. > > In theory the mutex should be per PCI device, however in practice we > know that there's only ever a single instance of the device in a given > system so we can use a global. > > Also take the mutex during initialization, as first port may be already > in use when second port is initialized. > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > Cc: Christian Fetzer <fetzer.ch@xxxxxxxxx> > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> The patch looks correct to me, Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thanks Jean for looking into this. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html