Re: [PATCH v3] i2c: imx: make bus recovery through pinctrl optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Li,

On Fri, Jan 15, 2016 at 04:46:06PM +0800, Li Yang wrote:
> On Fri, Jan 15, 2016 at 3:53 PM, Uwe Kleine-König
> <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> >> -     i2c_imx_init_recovery_info(i2c_imx, pdev);
> >> +     if (IS_ERR_OR_NULL(i2c_imx->pinctrl))
> >
> > I'd prefer to set i2c_imx->pinctrl to NULL if it's not used and then use
> >
> >         if (!i2c_imx->pinctrl)
> >
> > here. (Or maybe make i2c_imx_init_recovery_info aware of this situation
> > to keep the caller simple?)
> 
> Setting not used pointer to NULL might be a good coding practice
> generally.  But in this case neither the driver nor gpio framework
> checks if the pinctrl is NULL before accessing it.  We still need the
> driver to make sure pinctrl is not used in this situation.  The
> benefit of the proposed change seems to be pretty limited.  :)

At least it gets rid of IS_ERR_OR_NULL which is used wrongly more often
than not.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux