On Tue, Dec 15, 2015 at 08:14:34PM -0600, Suravee Suthikulpanit wrote:
> Hi Mika,
>
> On 12/15/15 15:55, Suravee Suthikulpanit wrote:
> >Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform
> >
> >Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> >---
> > drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> >index 57f623b..a027154 100644
> >--- a/drivers/i2c/busses/i2c-designware-platdrv.c
> >+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> >@@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
> > { "80860F41", 0 },
> > { "808622C1", 0 },
> > { "AMD0010", 0 },
> >+ { "AMDI0510", 0 },
> > { }
>
> Since this driver seems to be used by several SOCs, and we have been adding
> the HID from various SOC vendors. Do you think it would be better to assign
> a CID so that each SOC vendor can specify in their ACPI DSDT and we can
> match them here?
Sure _CID would work here.
> Then, we can also associate the FMCN and SSCN along with the CID, and
> guarantee compatibility.
Well, the driver checks those everytime it finds that the device has
ACPI companion regardless of _HID/_CID.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
