>-----Original Message----- >From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel- >owner@xxxxxxxxxxxxxxx] On Behalf Of Andy Shevchenko >Sent: Wednesday, November 25, 2015 10:33 PM >To: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux- >pm@xxxxxxxxxxxxxxx; Ingo Molnar <mingo@xxxxxxxxxx>; Peter Anvin ><hpa@xxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxxxxx>; Zhang, Rui ><rui.zhang@xxxxxxxxx>; Eduardo Valentin <edubezval@xxxxxxxxx>; Kweh, Hock >Leong <hock.leong.kweh@xxxxxxxxx> >Subject: Re: [PATCH v2 1/1] x86/platform/iosf_mbi: Remove duplicate definitions > >On Wed, 2015-11-25 at 15:20 +0100, Thomas Gleixner wrote: >> On Wed, 11 Nov 2015, Andy Shevchenko wrote: >> >> > The read and write opcodes are global for all units on SoC and even >> across >> > Intel SoCs. Remove duplication of corresponding constants. At the >> same time >> > convert all current users. >> > >> > No functional change. >> > >> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> > Cc: Ingo Molnar <mingo@xxxxxxxxxx> >> > Cc: Peter Anvin <hpa@xxxxxxxxx> >> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> >> > Cc: Zhang Rui <rui.zhang@xxxxxxxxx> >> > Cc: Eduardo Valentin <edubezval@xxxxxxxxx> >> > Cc: Hock Leong Kweh <hock.leong.kweh@xxxxxxxxx> > >Eduardo, Rui, can you provide your ACKs or comments about the patch? > Rui, I have reviewed the change on drivers/thermal/intel_quark_dts_thermal.c. Yes, I gave my ACK here. ��.n��������+%������w��{.n�����{��-��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥