On Sun, Sep 27, 2015 at 06:53:03PM +0200, Andrew Lunn wrote: > > >+ if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") || > > >+ of_device_is_compatible(np, "allwinner,sun6i-a31-i2c")) > > Rather than have to extend this list every so often, how about adding > a helper of_device_is_compatible_vendor(), so you can just have: I don't know, I kind of like the fact that it's explicit. If we ever have another SoC coming in with a different behaviour, we won't have to expand it back. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
