On Sun, Sep 27, 2015 at 06:05:35PM +0200, Olliver Schinagl wrote: > Hey Hans, > > On 27-09-15 16:57, Hans de Goede wrote: > >According to the datasheets to n factor for dividing the tclk is > >2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is > >on other mv64xxx implementations. > Ah! Just to be sure, i checked Kirkwood, Armada XP and Armada 370 datasheets. They all say n+1. > >+ if (of_device_is_compatible(np, "allwinner,sun4i-a10-i2c") || > >+ of_device_is_compatible(np, "allwinner,sun6i-a31-i2c")) Rather than have to extend this list every so often, how about adding a helper of_device_is_compatible_vendor(), so you can just have: > >+ if (of_device_is_compatible_vendor(np, "allwinner") Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html