Re: [PATCH v3 5/7] i2c: img-scb: use line_status instead of i2c->line_status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 10, 2015 at 03:50:05PM +0100, Sifan Naeem wrote:
> i2c->line_status accumulates the line status bits that have been seen
> with each interrupt. As we're only interested in that bit from the
> current interrupt, refer to line_status (the argument to img_i2c_auto)
> instead of i2c->line_status.
> 
> Signed-off-by: Sifan Naeem <sifan.naeem@xxxxxxxxxx>
> Reviewed-by: James Hartley <james.hartley@xxxxxxxxxx>

Acked-by: James Hogan <james.hogan@xxxxxxxxxx>

Thanks
James

> ---
>  drivers/i2c/busses/i2c-img-scb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
> index e4daebcdf824..049d193d01ac 100644
> --- a/drivers/i2c/busses/i2c-img-scb.c
> +++ b/drivers/i2c/busses/i2c-img-scb.c
> @@ -857,7 +857,7 @@ static unsigned int img_i2c_auto(struct img_i2c *i2c,
>  	}
>  
>  	/* Enable transaction halt on start bit */
> -	if (!i2c->last_msg && i2c->line_status & LINESTAT_START_BIT_DET) {
> +	if (!i2c->last_msg && line_status & LINESTAT_START_BIT_DET) {
>  		img_i2c_transaction_halt(i2c, true);
>  		/* we're no longer interested in the slave event */
>  		i2c->int_enable &= ~INT_SLAVE_EVENT;
> -- 
> 1.7.9.5
> 

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux