Re: [Patch v1] i2c: imx: add runtime pm support to improve the performance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > +	if (pm_runtime_suspended(i2c_imx->adapter.dev.parent))
> > > +		return IRQ_NONE;
> > > +
> > I don't claim to understand the runtime pm stuff, but I agree to the
> > previous reviewer that this smells fishy. If this is required it needs a
> > comment why.
> > 
> In fact, I agree you two reviewers' consideration. As I said, this is just to avoid system hang in worse case.
> Of course, I still don't catch the worse case. So I will remove this pm stuff.

So, there is a worst case where the system can hang now which is not
present in the current version of this driver (i.e. before your patch)?

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux