Re: [PATCH v2] i2c: davinci: Avoid sending to own address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 13, 2015 at 03:02:50PM +0200, Alexander Sverdlin wrote:
> Sending a message to own address locks the controller up in very bizarre state,
> it behaves as slave even if MDR register clearly states master. The controller

Eeks...

>  
> +	if (msg->addr == DAVINCI_I2C_OWN_ADDRESS)
> +		return -EIO;

I think we should return at least -EADDRNOTAVAIL here. Otherwise the
user might wonder if the slave is broken giving always IO errors. Maybe
we should also add a warning message, I leave that decision to you.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux