Re: [V4, 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kamal,

There's one change still missing (that I mentioned when reviewing v2 of the patchset):

>>>
What is the max len that can be supported? BSC_CNT_REG1_MASK = 63? Then
you should check against that.

Note Wolfram has introduced a way to validate the supported data length
at the i2c-core, which you should adapt:

commit b7f625840267b18ef1011cba0085bb7e237d76f7
Author: Wolfram Sang <wsa@xxxxxxxxxxxxx>
Date:   Mon Jan 5 23:45:59 2015 +0100

    i2c: add quirk checks to core

    Let the core do the checks if HW quirks prevent a transfer. Saves code
    from drivers and adds consistency.
<<<

So you should add struct i2c_adapter_quirks and set the max_read_len and max_write_len.

I have no more comment for the rest of the code.

Thanks,

Ray

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux