On Tue, May 12, 2015 at 09:05:05PM +0200, Wolfram Sang wrote: > On Wed, Apr 29, 2015 at 03:44:37PM +0300, Jarkko Nikula wrote: > > sizeof(struct i2c_client) is 1088 bytes on a CONFIG_X86_64=y build and > > produces following warning when CONFIG_FRAME_WARN is set to 1024: > > > > drivers/i2c/i2c-core.c: In function ‘acpi_i2c_space_handler’: > > drivers/i2c/i2c-core.c:367:1: warning: the frame size of 1152 bytes is > > larger than 1024 bytes [-Wframe-larger-than=] > > > > This is not critical given that kernel stack is 16 kB on x86_64 but lets > > reduce the stack usage by allocating the struct i2c_client from the heap. > > > > Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > > Besides it should be squashed with the previous patch, I'm fine with > this. Mika? No objections from me, Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
