No need to clear one struct i2c_client member variable since memset has already cleared all of them. Remove also one space intendation from err label. Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> --- drivers/i2c/i2c-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 987c124432c5..051aa3a811a8 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -283,7 +283,6 @@ acpi_i2c_space_handler(u32 function, acpi_physical_address command, memset(&client, 0, sizeof(client)); client.adapter = adapter; client.addr = sb->slave_address; - client.flags = 0; if (sb->access_mode == ACPI_I2C_10BIT_MODE) client.flags |= I2C_CLIENT_TEN; @@ -361,7 +360,7 @@ acpi_i2c_space_handler(u32 function, acpi_physical_address command, gsb->status = status; - err: +err: ACPI_FREE(ares); return ret; } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html