-- sent from mobile device On May 6, 2015 2:33:16 AM PDT, Jean Delvare <jdelvare@xxxxxxx> wrote: >Hi Ellen, > >On Mon, 4 May 2015 13:41:16 -0700, Ellen Wang wrote: >> On a CRC error while using hardware-supported PEC, an additional >> error bit is set in the auxiliary status register. If this bit >> isn't cleared, all subsequent operations will fail, essentially >> hanging the controller. >> >> The fix is simple: check, report, and clear the bit in >> i802_check_post(). Also, in case the driver starts with the >> hardware in that state, clear it in i801_check_pre() as well. > >You seem to be angry against 1s and 2s ;-) The subsystem is i2c and the >driver is i801, not the other way around. Heh. I guess I typed i2c-i801 too many times. Sorry. Please fix. >> Signed-off-by: Ellen Wang <ellen@xxxxxxxxxxxxxxxxxxx> >> --- >> This is essentially the patch from Jean Delvare, which handles >> the polling case while my original version didn't. (Thank you! >> Please add appropriate attribution if you wish.) > >Well, thanks for adding the comments, it's definitely helpful. This is >collaborative work :-) > >> >> I tested all the additional code paths by selectively commenting >> out code: with interrupts, without interrupts, relying on check_pre() >> to clear CRCE, no clearing of CRCE at all (baseline). > >Thanks a lot for testing. I'll perform some tests on my ICH5 system as >well and if everything passes I'll resend the patch with fixed subject, >description and credits. > >-- >Jean Delvare >SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
