On Tue, Mar 17, 2015 at 12:04:29PM +0000, Ben Dooks wrote: > The i2c-gpio driver can be used in systems where the GPIO itself is > provided by a GPIO driver that may be sleeping (for example, SPI or > USB). In this case, it is preferable to use the _cansleep() variants > of the GPIO code. > > We can only fix this up for the case where the i2c-gpio implementation > provides open-drain outputs as there are no gpio_direction_xxx_cansleep() > provided. > > This removes the issues on the customer system with the console constantly > showing the following warning: > > WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2389 gpiod_set_raw_value ??? It will silence a warning but will totally break the timing in case sleeping is needed? I'd think the warning is very suitable.
Attachment:
signature.asc
Description: Digital signature
