On Sun, Mar 8, 2015 at 12:50 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On 03/08/2015 12:30 PM, Andy Lutomirski wrote: > [ ... ] > >>> >>>> One other question: from my reading of the spec, it should be possible >>>> to >>>> augment this driver to expose a temporate sensor subdevice that shows >>>> recent cached temperatures from HW DIMM measurements. They would be >>>> redundant with the jc42 outputs, but it would be safe to use them even >>>> on >>>> systems without safe SMBUS arbitration. Should I do that as a followup >>>> later on? >>>> >>> >>> Without thinking too much about it, this should be a separate driver, >>> and I think it might actually be more valuable (since less risky) >>> than this entire patch set. >> >> >> The main problem there is that they'll fight over the PCI ids. >> > That is why we have mfd drivers. While that most likely won't be a > solution here (and I don't suggest it), you can use the same idea. > If can not be instantiated as pci driver, the alternative would be > to instantiate it as platform driver and let it get its pci > information from the parent device. > Hmm. It could make sense to have an Intel chipset driver that instantiates sub-devices for thermal monitoring, smbus, and EDAC. It might be a bit of a cleanup for sb-edac, too. Anyway, this isn't currently necessary. Let's deal with it when we get there. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
