On Tue, Feb 10, 2015 at 07:06:08PM +0200, Andy Shevchenko wrote: > There is no need to export functions that are used as the callbacks in the > struct dw_i2c_dev. Otherwise we get the following warnings: > > drivers/i2c/busses/i2c-designware-baytrail.c:63:5: warning: symbol 'baytrail_i2c_acquire' was not declared. Should it be static? > drivers/i2c/busses/i2c-designware-baytrail.c:114:6: warning: symbol 'baytrail_i2c_release' was not declared. Should it be static? > > While here, do few indentation fixes, remove i2c_dw_eval_lock_support() from > functions exported to the modules and redundant assignment of local sem > variable. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Acked-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> Yep. These remained from original versions of the patch that did use them as callbacks in struct dw_i2c_dev. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
