On Tue, Feb 10, 2015 at 07:06:07PM +0200, Andy Shevchenko wrote: > It seems we have same message for different return values in get_sem() and > baytrail_i2c_acquire(). I suspect this is just a typo, so this patch fixes it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Acked-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> Thanks for spotting this. Timeouts are infrequent and I didn't notice the error here. Dave > --- > drivers/i2c/busses/i2c-designware-baytrail.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-baytrail.c b/drivers/i2c/busses/i2c-designware-baytrail.c > index e9cb355..9b67655 100644 > --- a/drivers/i2c/busses/i2c-designware-baytrail.c > +++ b/drivers/i2c/busses/i2c-designware-baytrail.c > @@ -99,8 +99,8 @@ int baytrail_i2c_acquire(struct dw_i2c_dev *dev) > reset_semaphore(dev->dev); > > ret = iosf_mbi_read(BT_MBI_UNIT_PMC, BT_MBI_BUNIT_READ, > - PUNIT_SEMAPHORE, &sem); > - if (!ret) > + PUNIT_SEMAPHORE, &sem); > + if (ret) > dev_err(dev->dev, "iosf failed to read punit semaphore\n"); > else > dev_err(dev->dev, "PUNIT SEM: %d\n", sem); > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
