arc platform code updates (was Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+CC Guenter Roeck

On Tuesday 07 October 2014 03:00 PM, Christian Ruppert wrote:
> Hi Vineet,
>
> On Fri, Sep 26, 2014 at 09:20:20AM +0530, Vineet Gupta wrote:
>> Hi Chrisitian,
>>
>> On Monday 22 September 2014 10:53 PM, Christian Ruppert wrote:
>>> If there is no designware i2c in any of your platforms, simply ignore
>>> my message. From my point of view there is no need to move "select
>>> COMMON_CLK" up to the ARC architecture level.
>> I still ended up moving COMMON_CLK out of tb10x to arch/arc - due to consolidation
>> of .init_machine() callbacks - from platform to arc core.
>>
>> Give linux-next a spin (perhaps later today as I just pushed a build error in that
>> area).
>>
>> You'll like the almost empty platform file :-)
> This looks very nice indeed. Support for "standard" platforms is simple
> and elegant. The fact that most platforms won't need any specific
> support code at all (apart from drivers) goes well with the idea of
> device tree.  However, the kernel-doc comment for init_machine in
> mach_desc.h is now slightly confusing (still mentioning device tree).

A platform of future can still call of_platform_populate() etc to reparse the
stuff for say it's platform devices !
So I would think it is still relevant !

> With this patch there remains only a single detail we need to manage
> through platform-specific code: the reset handler. Today we still
> provide a patch for the machine_restart function in reset.c to our
> customers so that rebooting from the command line works. Do you have any
> plans/ideas to fix this one as well?

Patches are welcome ;-)

ATM, I dont have a specific use-case for my current platforms, so can't write the
code - you can propose a patch and then we can work out what's best in general for
all ARC platforms. BTW there's a series in flight on related topic from Guenter so
please take a look at that too for big picture !

http://www.spinics.net/linux/lists/kernel/msg1840650.html

Cheers,
-Vineet

>
> Greetings,
>   Christian
>

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux