Re: [PATCH v2] i2c: nomadik: factor platform data into state container

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 18, 2014 at 7:35 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:

>> -     of_property_read_u32(np, "clock-frequency", &pdata->clk_freq);
>> +     /* Default to 400 kHz if no frequency is given in the node */
>> +     if (of_property_read_u32(np, "clock-frequency", &nmk->clk_freq))
>> +             nmk->clk_freq = 400000;
>
> I can't really recommend this. 100kHz is something all devices support,
> but, although common, 400 kHz is already an extension of the standard.
>
> Let me know if I should fix this up for you.

I think this is done like this because all devices on all Nomadik variants
out there (Nomadik, Ux500) support 400kHz.

Buit change it if you prefer, nothing will break, it will just get slower :-)

I can easily fix that up ipso facto by modifying the device trees to
state 400kHz for them.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux