On 19 February 2014 10:40, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Tue, Feb 04, 2014 at 04:58:42PM +0100, Ulf Hansson wrote: >> Convert to the SET_PM_RUNTIME_PM macro while defining the runtime PM >> callbacks. This means the callbacks becomes available for both >> CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME, which is needed by drivers and >> power domains. > > This patch is wrong, because it causes build errors: > > drivers/amba/bus.c:126:18: error: 'pm_generic_suspend_late' undeclared here (not in a function) > drivers/amba/bus.c:127:18: error: 'pm_generic_resume_early' undeclared here (not in a function) > drivers/amba/bus.c:128:17: error: 'pm_generic_freeze_late' undeclared here (not in a function) > drivers/amba/bus.c:129:16: error: 'pm_generic_thaw_early' undeclared here (not in a function) > drivers/amba/bus.c:130:19: error: 'pm_generic_poweroff_late' undeclared here (not in a function) > drivers/amba/bus.c:131:19: error: 'pm_generic_restore_early' undeclared here (not in a function) > > The failing configuration is: > > # CONFIG_SUSPEND is not set > CONFIG_PM_RUNTIME=y > CONFIG_PM=y > Thanks for spotting this! I thought I had tested all the various combinations, but obvisouly not. Anyway to add some more clarify; it is not this patch that causes the issue. It's patch 2, which introduces the late/early callbacks. Though the problem need to be fixed in the PM core, pm_generic_suspend_late etc is not set to NULL for !CONFIG_PM_SLEEP, they should. I guess we should put patch 2 on hold until, right? Kind regards Ulf Hansson > -- > FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation > in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. > Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
