On Sat, Feb 15, 2014 at 04:27:37PM +0100, Wolfram Sang wrote: > On Tue, Feb 04, 2014 at 04:31:19PM +0200, Mika Westerberg wrote: > > Intel Baytrail I2C controllers can be enumerated from PCI as well as from > > ACPI. In order to support this add the Baytrail PCI IDs to the driver. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Basically fine, one question: > > > - snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci-%d", > > - adap->nr); > > + > > + if (adap->nr < 0) > > + snprintf(adap->name, sizeof(adap->name), "i2c-designware-pci"); > > + else > > + snprintf(adap->name, sizeof(adap->name), > > + "i2c-designware-pci-%d", adap->nr); > > Maybe we just drop the "-%d" suffix entirely? I suggested that already when Benson (CC'd) sent his Haswell patch series. His opinion was that it is useful in certain cases to know the bus number (like grepping /proc/interrupts, IIRC). For Baytrail we don't need it so if nobody objects, I'll just go ahead and drop it. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
