Hi,
No need to quote the whole message if you reply only to a bit of it.
> > module_init(at24_init);
> >
> > static void __exit at24_exit(void)
> > {
> > i2c_del_driver(&at24_driver);
> > }
> > module_exit(at24_exit);
>
> Couldn't you use module_i2c_driver() instead of this?
He didn't write that code. It doesn't have a + at the beginning. He used
the whole driver as context, which is highly unusual. A context of 3
lines is usually good enough.
>
> > MODULE_DESCRIPTION("Driver for most I2C EEPROMs");
> > MODULE_AUTHOR("David Brownell and Wolfram Sang");
>
> I would personally put your name in here if I were you, otherwise
> David and Wolfram might get contacted by some people instead of you
> (at least based on this).
See above. He changed only 10 lines. Not enough for copyright IMO.
> PS.: Fixing the broken i2c mailing list typo, and updating Wolfram's
> address from the broken (obsolete?) version.
It came through to the i2c list? What was wrong?
Regards,
Wolfram
Attachment:
signature.asc
Description: Digital signature
