On 08/01/2014 13:55, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Gregory CLEMENT wrote: >> diff --git a/include/linux/mvebu-soc-id.h b/include/linux/mvebu-soc-id.h >> new file mode 100644 >> index 000000000000..31654252fe35 >> --- /dev/null >> +++ b/include/linux/mvebu-soc-id.h >> +#ifdef CONFIG_ARCH_MVEBU >> +int mvebu_get_soc_id(u32 *dev, u32 *rev); >> +#else >> +static inline int mvebu_get_soc_id(u32 *dev, u32 *rev) >> +{ >> + return -1; >> +} >> +#endif >> + >> +#endif /* __LINUX_MVEBU_SOC_ID_H */ > > With the quirk handling in patch 3, I think we should remove the public interface > and EXPORT_SYMBOL(), as well as move this header file into mach-mvebu. > > That said, we may want to add support for the soc_bus later on (not as part of the > stable bug fix) to make it possible to query the soc version from user space through > the standard sysfs files. We could do it later indeed. For having a more acceptable patch for stable I will move this header file into mach-mvebu. Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html