On 08/01/2014 13:52, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Gregory CLEMENT wrote: > >> static void __init armada_370_xp_dt_init(void) >> { >> + i2c_quirk(); >> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); >> } > > I'd prefer to enable the quirk only on machines that we know may be affected, i.e. > OpenBlocks AX3-4. That would make it easier in the future for everyone to figure > out whether they need to include the quirk in their kernels or not, depending > on whether they want to support these machines. Just a precaution in case we > end up having lots of quirks in the long run. You means something like the following code ? static void __init armada_370_xp_dt_init(void) { + if (of_machine_is_compatible("plathome,openblocks-ax3-4")) + i2c_quirk(); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html