Dear Gregory CLEMENT, On Tue, 7 Jan 2014 17:35:04 +0100, Gregory CLEMENT wrote: > if (of_device_is_compatible(np, "marvell,mv78230-i2c")) { > - drv_data->offload_enabled = true; > drv_data->errata_delay = true; > + > + if (!of_find_property(np, "offload-broken", NULL)) > + drv_data->offload_enabled = true; > } I think of_property_read_bool() is more appropriate than of_find_property() in this situation, because offload-broken is indeed a boolean property. Something like: drv_data->offload_enable = !of_property_read_bool(np, "offload-broken"); Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html