2014/1/3 Wolfram Sang <wsa@xxxxxxxxxxxxx>: > On Fri, Dec 20, 2013 at 04:12:55PM +0100, jean-jacques hiblot wrote: >> From: jean-jacques hiblot <jjhiblot@xxxxxxxxx> >> >> Clean-up properly when a transfer fails for whatever reason. >> Cancel the transfer when the process is signaled. > > Please describe what you do a little. I wonder how you can remove so > much code while keeping the functionality? Well there are 2 reasons why so much code went away. 1) The iic_wait_for_tc() function wasn't used anymore (it should have disappeared in an earlier patch but the diff was terrible to read) 2) the whole abortion scheme is different. It's now done as a part of the data transfer. The reason is that the controller doesn't react properly to abortion when it's not done at the right moment. The idea here is to abort the transfer right after sending the next byte to keep the controller happy. If the abortion is asked at the wrong moment, the controller may not set the abortion complete flag and the next transfer may fail. > >> >> Signed-off-by: jean-jacques hiblot <jjhiblot@xxxxxxxxxxxxxxx> > >> - out_8(&iic->cntl, CNTL_HMT); >> + DBG(dev, "aborting transfer\n"); >> + /* transfer should be aborted within 10ms */ >> + end = jiffies + 10; > > Eeks, msecs_to_jiffies() macro please! > > And please consider running checkpatch and sparse over your code. Sparse > gives, for example: > > drivers/i2c/busses/i2c-ibm_iic.c:418:24: warning: incorrect type in argument 1 (different address spaces) > drivers/i2c/busses/i2c-ibm_iic.c:418:24: expected unsigned char const volatile [noderef] [usertype] <asn:2>*addr > drivers/i2c/busses/i2c-ibm_iic.c:418:24: got unsigned char *<noident> > > (This probably due to patch 1 or 2, I'd guess) > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
