Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18-12-2013 15:43, Wolfram Sang wrote:

@@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = {
  	CLKDEV_CON_ID("mtu2_fck", &mstp_clks[MSTP33]),

  	/* ICK */
+	CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]),
+	CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]),
+	CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]),
+	CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]),

    These belong to some other place, the group marked by /* ICK */
is only for CLKDEV_ICK_ID().

So, I'll create a /* DEV */ prefix?

I really don't know. Other places have /* MSTP */ comment in this case despite all clocks, CLKDEV_DEV_ID() and CLKDEV_ICK_ID() are really MSTP clocks. I considered the idea of separating CLKDEV_ICK_ID() under /* ICK */ comment silly from the very start but Simon didn't listen to me.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux