Re: [PATCH] i2c-mux: Inherit retry count from parent controller for muxed bus.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 9, 2013 at 12:08 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Sun, Dec 08, 2013 at 11:48:20AM +0100, Elie De Brauwer wrote:
>> Today if a mux i2c bus gets created the default retry count of the
>> muxed bus is zero. Hence it it possible that you end up with a
>> situation where the parent controller sets a default retry count
>> which gets applied and used while the muxed bus (using the same
>> controller) has a default retry count of zero. This can be solved
>> by initializing the retry count of the muxed bus by the retry count
>> of the parent at creation time.
>>
>> Signed-off-by: Elie De Brauwer <eliedebrauwer@xxxxxxxxx>
>
> Makes sense. Have you checked the timeout value, too?
>

Point taken, I hadn't bumped into this since i2c_add_mux_adapter() calls
i2c_add_adapter() which essentially sets is to 1 second if it is zero. But
it makes sense indeed to also use this value from the parent. I'll post an
updated version later today.

Thanks
E.


-- 
Elie De Brauwer
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux