Re: [PATCH] ARM: at91: sama5d3: reduce TWI internal clock frequency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/11/2013 16:07, Ludovic Desroches :
On Fri, Nov 22, 2013 at 03:58:35PM +0100, Wolfram Sang wrote:
On Fri, Nov 22, 2013 at 03:51:41PM +0100, Ludovic Desroches wrote:
Hi Wolfram,

On Fri, Nov 22, 2013 at 03:33:51PM +0100, Wolfram Sang wrote:
On Fri, Nov 22, 2013 at 03:07:08PM +0100, ludovic.desroches@xxxxxxxxx wrote:
From: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>

There are still I2C unexpected behaviors which are solved by reducing TWI
internal frequency.

Cc: <stable@xxxxxxxxxxxxxxx> #3.10+
Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>

I think the commit message needs more details. Is this a true bugfix
because the real bus frequency was too high because of the wrong
divider? Is this a workaround which makes things work but will make the
bus frequency slower than it should be?

This fix doesn't concern the i2c bus frequency, only the internal IP frequency.

TWI has been validated at 66MHz. With some devices, transfer hangs during i2c
frame transmission. This issue disappears when reducing the internal frequency
of the IP. Maybe there is some oversampling on i2c signals.
Unfortunately, I have no clear status about the root cause that's why
the commit message was imprecise.

This paragraph is a way better commit message IMO :)


Ok I'll update it.


Ludo, you can also add my:

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

Bye,

Thanks for the review Wolfram.

Regards

Ludovic




--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux