Hi Jean-Jacques, [...] >> >>> + if (ext_status & EXTSTS_LA) >>> + dev_dbg(dev->dev, "Lost arbitration\n"); >> >> Ditto > I don't know if this is really an error. Arbitration loss wan be very > common in a multi master environement. What about dev_warn ou dev_info I think dev_warn should be fine but I don't have a strong opinion on it. > >> >>> + if (ext_status & EXTSTS_ICT) >>> + dev_dbg(dev->dev, "Incomplete transfer\n"); >> >> Ditto >> >>> + if (ext_status & EXTSTS_XFRA) >>> + dev_dbg(dev->dev, "Transfer aborted\n"); >> >> Ditto >> > I'll use dev_err instead for those two. > > [...] >> Is it related to the topic of this patch? > I needed the pointer to the struct device for the dev_err, dev_dbg etc., > so I stored it in the private structure. If it's better I can modify the > driver to get it from adap->dev.parent when needed. What I have in mind was more to write a separate patch for this kind of improvement Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
