Re: [PATCH -next] i2c: bcm-kona: fix error return code in bcm_kona_i2c_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 18, 2013 at 5:03 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return a negative error code from the bus speed parse
> error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-bcm-kona.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c
> index 865e5dd..036cf03 100644
> --- a/drivers/i2c/busses/i2c-bcm-kona.c
> +++ b/drivers/i2c/busses/i2c-bcm-kona.c
> @@ -792,7 +792,8 @@ static int bcm_kona_i2c_probe(struct platform_device *pdev)
>         }
>
>         /* Parse bus speed */
> -       if (bcm_kona_i2c_assign_bus_speed(dev))
> +       rc = bcm_kona_i2c_assign_bus_speed(dev);
> +       if (rc)
>                 goto probe_disable_clk;
>
>         /* Enable internal clocks */
>

Looks good.  Thanks.

Reviewed-by: Tim Kryger <tim.kryger@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux