Hi Wolfram Thank you for your review > > static struct platform_device_id rcar_i2c_id_table[] = { > > - { "i2c-rcar", I2C_RCAR_H1 }, > > - { "i2c-rcar_h1", I2C_RCAR_H1 }, > > - { "i2c-rcar_h2", I2C_RCAR_H2 }, > > + { "i2c-rcar", I2C_RCAR_GEN1 }, > > + { "i2c-rcar_gen1", I2C_RCAR_GEN1 }, > > + { "i2c-rcar_gen2", I2C_RCAR_GEN2 }, > > {}, > > Renaming the platform_device_ids will cause regressions, too! The user who is using this driver is using "i2c-rcar" only at this point. "i2c-rcar_h1/i2c-rcar_h2" user will appear. but not exist now. So, I think it can keep compatible. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html