On Thu, 2013-10-10 at 12:39 +0200, Michal Simek wrote: > Code changes to fix checkpatch warnings listed below. > - WARNING: quoted string split across lines [] > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c [] > @@ -271,11 +271,8 @@ static void xiic_read_rx(struct xiic_i2c *i2c) > > bytes_in_fifo = xiic_getreg8(i2c, XIIC_RFO_REG_OFFSET) + 1; > > - dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d" > - ", SR: 0x%x, CR: 0x%x\n", > - __func__, bytes_in_fifo, xiic_rx_space(i2c), > - xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), > - xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); > + dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d", > + __func__, bytes_in_fifo, xiic_rx_space(i2c)); This is a pretty odd way of silencing checkpatch by eliminating content. Aren't the register values useful information? You've also removed the terminating newline. It's necessary to avoid possible dmesg output log message interleaving. Please put it back. A more normal style fix would be to coalesce the format. checkpatch will ignore lines exceeding 80 columns for these formats. dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d, SR: 0x%x, CR: 0x%x\n", __func__, bytes_in_fifo, xiic_rx_space(i2c), xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); This passes checkpatch cleanly. etc... -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
