On Wed, Aug 07, 2013 at 04:35:46PM +0200, Wolfram Sang wrote: > > > But we shouldn't use it alone: we should always use: > > compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c"; > > > > From my point of view using "marvell,mv78230-i2c" alone is an error. > > > > Wolfram what is your opinion on it? > > It is not strictly an error, but risky. If you use an older Kernel > version (or other OS) which only offers "mv64xxx" you will have no > match. Although the driver theoretically could have basic support for > all mv64xxx variants skipping all additional features of later IP > revisions. I agree here. The driver is advertising what IP blocks it can handle, so it makes sense to add both strings since it can handle both. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
