On 16/07/2013 10:05, Maxime Ripard wrote: > Hi Gregory, > > On Mon, Jul 15, 2013 at 04:24:36PM +0200, Gregory CLEMENT wrote: >> The I2C Transaction Generator offloads CPU from managing I2C transfer step by step. >> >> This feature is currently only available on Armada XP, so usage of this mechanism is activated through device tree. >> >> Based on the work of Piotr Ziecik and rewrote to use the new way of handling multiples i2c messages. >> >> Signed-off-by: Piotr Ziecik <kosmo@xxxxxxxxxxxx> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> --- drivers/i2c/busses/i2c-mv64xxx.c | 207 >> ++++++++++++++++++++++++++++++++++++--- 1 file changed, 196 insertions(+), 11 deletions(-) > > [...] > >> + /* + * For controllers embedded in new SoCs activate the + * Transaction Generator support. + */ + if (of_device_is_compatible(np, "marvell,mv78230-i2c")) + >> drv_data->offload_enabled = true; + > > Do you have a reason for not adding it to the match table? I mean, you will introduce a new compatible here, but if that compatible is used alone, won't probe the driver? That doesn't > seem very right to me. But we shouldn't use it alone: we should always use: compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c"; >From my point of view using "marvell,mv78230-i2c" alone is an error. Wolfram what is your opinion on it? > > Also, you should probably add it to the bindings documentation. See the patch 3 for the bindings documentation. > > Maxime > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
