On Thu, Mar 21, 2013 at 03:45:29PM +0530, Viresh Kumar wrote: > On 21 March 2013 15:06, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > > I applied V11 of the core changes with minor modifications. > > Wow!! Thanks. > > > I do wonder > > about the hook in the designware driver. You apply the recovery on > > transfer timeout. I think this should go into the timeout of > > i2c_dw_wait_bus_not_busy()? > > Hmm.. Rajeev/Shiraz were the guys who tested this code earlier and i am > sure we were failing in this piece of code, which i just fixed and so > i2c_dw_wait_bus_not_busy() didn't fail for us. > > Below is a conversation that we had with Uwe some time back on the exact > problem we faced and it was a bit different from the traditional problem. > > So, maybe we need bus recovery at both places: i2c_dw_wait_bus_not_busy() > (for the traditional hang) and during transfer (for our case). DW_IC_STATUS_ACTIVITY check in i2c_dw_wait_bus_not_busy actually only represents controller activity status and has nothing to do with real bus status. -- regards Shiraz -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
