On Fri, Jan 25, 2013 at 03:17:48PM +0530, Viresh Kumar wrote: > Add i2c bus recovery infrastructure to i2c adapters as specified in the i2c > protocol Rev. 03 section 3.1.16 titled "Bus clear". > > http://www.nxp.com/documents/user_manual/UM10204.pdf > > Sometimes during operation i2c bus hangs and we need to give dummy clocks to > slave device to start the transfer again. Now we may have capability in the bus > controller to generate these clocks or platform may have gpio pins which can be > toggled to generate dummy clocks. This patch supports both. > > This patch also adds in generic bus recovery routines gpio or SCL line based > which can be used by bus controller. In addition controller driver may provide > its own version of the bus recovery routine. > > This doesn't support multi-master recovery for now. > > Reviewed-by: Paul Carpenter <paul@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Code-wise I am mostly satisfied, except that I need to think about clock-stretching a little more. We could add that later, too. However, while I understand you are keen to get rid of this series ASAP, it seems that this eagerness results in some sloppyness which is a bit cumbersome (most lines changed since last time have something to comment on). So, I'll try a different review style this time and let you do the detective work :) 1) Please be strict and consistent with spaces around operators. 2) Make sure the warnings and printouts match the code 3) Take the printouts serious and invest a thought if they can be further improved. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
