On Monday 05 November 2012 01:23 PM, Felipe Balbi wrote: > Hi, > > On Sun, Nov 04, 2012 at 04:14:29PM +0530, Shubhrajyoti D wrote: >> The dtrev is used only for the comments. Remove the same and use >> the scheme instead to know if it is version2. >> >> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> > I would drop dtrev completely and not use scheme to "emulate" it. However for ver2 ie omap4plus and previous versions the register map is different. So the scheme may still be required. > dtrev > is wrong and unnecessary; it was only created due to the wrong > assumption that HW revision register was wrong. Looks like that > assumption was made based on the driver which is clearly wrong wrt > revision detection. > > Also, when dropping dtrev, also drop it from platform_data and > omap_hwmod database (could be done on a separate patch). OK would do that. > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
