Hi, On Tue, Jul 17, 2012 at 10:40:47AM +0200, Heiko Schocher wrote: > add of support for the davinci i2c driver. > > Signed-off-by: Heiko Schocher <hs@xxxxxxx> > Signed-off-by: Sekhar Nori <nsekhar@xxxxxx> > Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: devicetree-discuss@xxxxxxxxxxxxxxxx > Cc: linux-i2c@xxxxxxxxxxxxxxx > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> > Cc: Sekhar Nori <nsekhar@xxxxxx> > Cc: Wolfgang Denk <wd@xxxxxxx> > Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > --- > - changes for v2: > - add comments from Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>: > - use "cell-index" instead "id" > - OF_DEV_AUXDATA in the machine code, instead pre-define platform > device name > - add comment from Grant Likely: > - removed "id" resp. "cell-index" completely > - fixed documentation > - use of_match_ptr() > - use devm_kzalloc() for allocating plattform data mem > - fixed a whitespace issue > - no changes for v3 > - changes for v4 > remove "pinmux-handle" property as discussed here: > http://www.spinics.net/lists/arm-kernel/msg175701.html > with Nori Sekhar > > - changes for v5 > add comments from Grant Likely: > - do not change value of dev->dev->platform_data, instead > hold a copy in davinci_i2c_dev. > > - changes for v6: > add comments from Sekhar Nori: > - removed unneccessary include > - merge patch from Sekhar Nori: > setup the newly introduced dev->pdata member correctly once in > probe -> i2c_get_plattformdata(() not needed, remove a lot of > checks for pdata in code > - add Signed-off-by: Sekhar Nori <nsekhar@xxxxxx> > - patch no longer in patchserie, as it has no dependencies. > --- > .../devicetree/bindings/arm/davinci/i2c.txt | 31 ++++++++++++ > drivers/i2c/busses/i2c-davinci.c | 50 +++++++++++++++---- > 2 files changed, 70 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/davinci/i2c.txt > > diff --git a/Documentation/devicetree/bindings/arm/davinci/i2c.txt b/Documentation/devicetree/bindings/arm/davinci/i2c.txt > new file mode 100644 > index 0000000..e98a025 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/davinci/i2c.txt This should go bindings/i2c/... > @@ -0,0 +1,31 @@ > +* Texas Instruments Davinci I2C > + > +This file provides information, what the device node for the > +davinci i2c interface contain. > + > +Required properties: > +- compatible: "ti,davinci-i2c"; > +- reg : Offset and length of the register set for the device > + > +Recommended properties : > +- interrupts : <a> standard interrupt property. > +- clock-frequency : desired I2C bus clock frequency in Hz. > + > +Optional properties: > +- bus-delay: bus delay in usec See my mail to Andrew regarding the timeout property in the mv64xxx driver. I'd like to skip the binding discussion for now in order to make it into 3.6. Is it okay for you to drop this binding and use a sane default? Rest looks good (from a visual review), Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
